Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2515393002: Revert of Add check_build_deps step to gclient runhooks (Closed)

Created:
4 years, 1 month ago by mdjones
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add check_build_deps step to gclient runhooks (patchset #2 id:20001 of https://codereview.chromium.org/2505413003/ ) Reason for revert: Breaking builds on Cast Android (dbg), Android Cronet x86 Builder (dbg), etc.: Missing build dependencies. Try running 'build/install-build-deps.sh' Original issue's description: > Add check_build_deps step to gclient runhooks > > This CL adds a build hook to ensure that any necessary build > dependencies are installed before proceeding with the > build. A failure would indicate install_build_deps.sh > needs to be rerun. > > BUG=666937 > R=dpranke@chromium.org > > Committed: https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230 > Cr-Commit-Position: refs/heads/master@{#433603} TBR=dpranke@chromium.org,thomasanderson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=666937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -34 lines) Patch
M DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D build/check-build-deps.py View 1 chunk +0 lines, -16 lines 0 comments Download
M build/install-build-deps.sh View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mdjones
Created Revert of Add check_build_deps step to gclient runhooks
4 years, 1 month ago (2016-11-21 19:45:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515393002/1
4 years, 1 month ago (2016-11-21 19:46:24 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 19:48:10 UTC) #5
Failed to apply patch for DEPS:
While running git apply --index -p1;
  error: patch failed: DEPS:537
  error: DEPS: patch does not apply

Patch:       DEPS
Index: DEPS
diff --git a/DEPS b/DEPS
index
10ff84d31364bc65f0d29673b338eaaa6406213e..d3f060c643381849d1dbbc900837e7423d71c23d
100644
--- a/DEPS
+++ b/DEPS
@@ -537,16 +537,6 @@
     ],
   },
   {
-    # Ensure the host environment has the necessary packages required to build
-	# Chromium.
-	'name': 'check_build_deps',
-	'pattern': '.',
-	'action': [
-        'python',
-        'src/build/check-build-deps.py',
-    ],
-  },
-  {
     # Ensure that while generating dependencies lists in .gyp files we don't
     # accidentally reference any .pyc files whose corresponding .py files have
     # already been deleted.

Powered by Google App Engine
This is Rietveld 408576698