Pass deps to emma_instr target

Pass deps to emma_instr target

This makes emma_instr work with the generated Java file.

BUG=666696
Committed: https://crrev.com/123bee15a8403bd26d896f5cd5f0d5116c1b39be
Cr-Commit-Position: refs/heads/master@{#433665}

[michaelbai, 2016-11-21 18:56:11]

michaelbai@chromium.org changed reviewers:
+ agrieve@chromium.org

[michaelbai, 2016-11-21 18:57:08]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 18:57:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-11-21 19:27:44]

lgtm

https://codereview.chromium.org/2515383002/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2515383002/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:2120: deps += [
":$_process_prebuilt_target_name" ]
nit: deps can be undefined here I believe. Should add in:

if (!defined(deps)) {
  deps = [] 
}

[michaelbai, 2016-11-21 19:43:46]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2016-11-21 19:43:46]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2515383002/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2016-11-21 19:44:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelbai, 2016-11-21 19:44:22]

https://codereview.chromium.org/2515383002/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2515383002/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:2120: deps += [
":$_process_prebuilt_target_name" ]
On 2016/11/21 19:27:44, agrieve wrote:
> nit: deps can be undefined here I believe. Should add in:
> 
> if (!defined(deps)) {
>   deps = [] 
> }

Done.

[commit-bot: I haz the power, 2016-11-21 22:05:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479757426448670,
"parent_rev": "643d453b057a1318f2daea7cb9e5dcfdcc0bf734", "commit_rev":
"65db59b03334e8883b9d9644f3145e115e23e566"}

[commit-bot: I haz the power, 2016-11-21 22:05:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-21 22:08:21]

Description was changed from

==========
Pass deps to emma_instr target

This makes emma_instr work with the generated Java file.

BUG=666696
==========

to

==========
Pass deps to emma_instr target

This makes emma_instr work with the generated Java file.

BUG=666696

Committed: https://crrev.com/123bee15a8403bd26d896f5cd5f0d5116c1b39be
Cr-Commit-Position: refs/heads/master@{#433665}
==========

[commit-bot: I haz the power, 2016-11-21 22:08:22]

Patchset 2 (id:??) landed as
https://crrev.com/123bee15a8403bd26d896f5cd5f0d5116c1b39be
Cr-Commit-Position: refs/heads/master@{#433665}