Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: third_party/WebKit/Source/web/CompositorProxyClientFactoryImpl.h

Issue 2515363002: Introduce AnimationWorkletProxyClient and necessary plumbing to get it in worklet messaging proxy. (Closed)
Patch Set: address feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CompositorProxyClientFactoryImpl_h
6 #define CompositorProxyClientFactoryImpl_h
7
8 #include "core/dom/CompositorProxyClientFactory.h"
9 #include "platform/heap/Handle.h"
10
11 namespace blink {
12
13 class CompositorMutatorImpl;
14
15 class CompositorProxyClientFactoryImpl final
16 : public GarbageCollectedFinalized<CompositorProxyClientFactoryImpl>,
17 public CompositorProxyClientFactory {
18 public:
19 explicit CompositorProxyClientFactoryImpl(CompositorMutatorImpl*);
20 CompositorProxyClient* create(CompositorProxyClient::Type) override;
dcheng 2016/11/28 21:17:32 Nit: It's nice to annotate this with something lik
majidvp 2017/01/20 15:48:57 I ended up removing the factory. So this is no lon
21
22 DEFINE_INLINE_TRACE() {}
23
24 private:
25 CrossThreadPersistent<CompositorMutatorImpl> m_mutator;
dcheng 2016/11/28 21:17:32 This code has a lot of CrossThreadPersistents...
haraken 2016/11/29 02:35:36 Yeah, I agree that this needs to be CrossThreadPer
majidvp 2017/01/20 15:48:57 OK. I realized the factory is not really doing muc
26 };
27
28 } // namespace blink
29
30 #endif // CompositorProxyClientFactoryImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698