Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.h

Issue 2515363002: Introduce AnimationWorkletProxyClient and necessary plumbing to get it in worklet messaging proxy. (Closed)
Patch Set: address feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef AnimationWorkletProxyClientImpl_h
6 #define AnimationWorkletProxyClientImpl_h
7
8 #include "core/dom/AnimationWorkletProxyClient.h"
9 #include "platform/graphics/CompositorAnimator.h"
10 #include "platform/heap/Handle.h"
11 #include "wtf/Noncopyable.h"
12
13 namespace blink {
14
15 class CompositorMutatorImpl;
16
17 // Mediates between one Animator and the associated CompositorMutatorImpl. There
18 // is one AnimationWorkletProxyClientImpl per Animator but there may be multiple
19 // for a given mutator and animatorWorklet.
20 //
21 // Should be accessed only on the compositor thread.
dcheng 2016/11/28 21:17:31 This comment seems to be directly in opposition to
majidvp 2017/01/20 15:48:57 I clarified the comment. This is similar to a work
22 class AnimationWorkletProxyClientImpl final
23 : public GarbageCollectedFinalized<AnimationWorkletProxyClientImpl>,
24 public AnimationWorkletProxyClient,
25 public CompositorAnimator {
26 WTF_MAKE_NONCOPYABLE(AnimationWorkletProxyClientImpl);
27 USING_GARBAGE_COLLECTED_MIXIN(AnimationWorkletProxyClientImpl);
28
29 public:
30 AnimationWorkletProxyClientImpl(CompositorMutatorImpl*);
dcheng 2016/11/28 21:17:32 Nit: explicit Or even better, add |CompositorMuta
31 DECLARE_VIRTUAL_TRACE();
32
33 // CompositorAnimator:
34 bool mutate(double monotonicTimeNow,
35 CompositorMutableStateProvider*) override;
36
37 // CompositorProxyClient:
38 void registerCompositorProxy(CompositorProxy*) override;
39 void unregisterCompositorProxy(CompositorProxy*) override;
40
41 private:
42 CrossThreadPersistent<CompositorMutatorImpl> m_mutator;
43 HeapHashSet<WeakMember<CompositorProxy>> m_proxies;
44 };
45
46 } // namespace blink
47
48 #endif // AnimationWorkletProxyClientImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698