Introduce AnimationWorkletProxyClient and necessary plumbing to get it in worklet messaging proxy.

third_party/WebKit/Source/core/dom/CompositorProxyClient.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CompositorProxyClient_h
 #define CompositorProxyClient_h
 
 #include "core/CoreExport.h"
-#include "core/workers/WorkerClients.h"
-#include "wtf/Noncopyable.h"
-
-#include <v8.h>
+#include "platform/heap/Handle.h"
 
 namespace blink {
 
 class CompositorProxy;
-class WorkerClients;
-class WorkerGlobalScope;
 
-class CORE_EXPORT CompositorProxyClient : public Supplement<WorkerClients> {
-  WTF_MAKE_NONCOPYABLE(CompositorProxyClient);
+class CORE_EXPORT CompositorProxyClient : public GarbageCollectedMixin {

[dcheng, 2016/11/28 21:17:31]

Nit: it might be slightly simpler just to make this a GarbageCollectedFinalized:
it feels weird for derived classes to have to call
CompositorProxyClient::trace() when nothing is ever traced.

Alternatively... would it make sense to just have createWorkerClient() and
createWorkletClient() here and just have it return an
AnimationProxyWorkletClient / CompositorProxyWorkerClient here? Is there code
that will need to work with either one in a transparent manner?

[majidvp, 2017/01/20 15:48:57]

Good idea. Done!
I don't think I can construct the clients here. To construct one, we need
to have a reference to CompositorMutatorImpl which is available in WebViewImpl
which is why the clients are constructed there.

+ public:
+  enum Type { kWorkerClient, kWorkletClient };

[dcheng, 2016/11/28 21:17:31]

Nit: can we document the distinction between 'worker' and 'worklet' somewhere? I
don't actually know what the difference is...

[majidvp, 2017/01/20 15:48:57]

I don't know if there is a design doc for worklets but ikilpatrick@ maybe able
to
point one out. Here is the spec which talks about the difference between worker
and a worklet https://drafts.css-houdini.org/worklets/.

 
- public:
-  CompositorProxyClient() {}
+  DEFINE_INLINE_VIRTUAL_TRACE() {}
 
-  static CompositorProxyClient* from(WorkerClients*);
-  static const char* supplementName();
-
-  virtual void dispose() = 0;
-  virtual void setGlobalScope(WorkerGlobalScope*) = 0;
-  virtual void requestAnimationFrame() = 0;
   virtual void registerCompositorProxy(CompositorProxy*) = 0;
   // It is not guaranteed to receive an unregister call for every registered
   // proxy. In fact we only receive one when a proxy is explicitly
   // disconnected otherwise we rely on oilpan collection process to remove the
   // weak reference to the proxy.
   virtual void unregisterCompositorProxy(CompositorProxy*) = 0;
 };
 
-CORE_EXPORT void provideCompositorProxyClientTo(WorkerClients*,
-                                                CompositorProxyClient*);
-
 }  // namespace blink
 
 #endif  // CompositorProxyClient_h