Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2515353006: Fix USB device permissions tests (Closed)

Created:
4 years ago by Lof
Modified:
4 years ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix USB device permissions tests BUG=629223 R=tbarzic, reillyg@chromium.org, meacer@chromium.org Committed: https://crrev.com/438efe78ab6e2caa5d5a63967aea4b6544831dc8 Cr-Commit-Position: refs/heads/master@{#434312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M extensions/common/permissions/usb_device_permission_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Lof
Tests passed with warning: https://cs.chromium.org/chromium/src/extensions/common/manifest_handlers/permissions_parser.cc?q=ParseHelper&sq=package:chromium&l=220
4 years ago (2016-11-23 13:31:44 UTC) #1
tbarzic
lgtm
4 years ago (2016-11-23 20:32:05 UTC) #2
Reilly Grant (use Gerrit)
lgtm but do we understand why these tests passed before?
4 years ago (2016-11-23 20:40:46 UTC) #3
tbarzic
On 2016/11/23 at 20:40:46, reillyg wrote: > lgtm but do we understand why these tests ...
4 years ago (2016-11-23 20:54:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515353006/1
4 years ago (2016-11-23 21:40:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on ...
4 years ago (2016-11-23 23:42:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515353006/1
4 years ago (2016-11-24 04:43:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515353006/1
4 years ago (2016-11-24 06:53:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 08:54:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515353006/1
4 years ago (2016-11-24 10:05:51 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 12:05:44 UTC) #19
commit-bot: I haz the power
4 years ago (2016-11-24 12:08:18 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/438efe78ab6e2caa5d5a63967aea4b6544831dc8
Cr-Commit-Position: refs/heads/master@{#434312}

Powered by Google App Engine
This is Rietveld 408576698