|
|
Chromium Code Reviews
DescriptionFix USB device permissions tests
BUG=629223
R=tbarzic, reillyg@chromium.org, meacer@chromium.org
Committed: https://crrev.com/438efe78ab6e2caa5d5a63967aea4b6544831dc8
Cr-Commit-Position: refs/heads/master@{#434312}
Patch Set 1 #
Messages
Total messages: 21 (9 generated)
Tests passed with warning: https://cs.chromium.org/chromium/src/extensions/common/manifest_handlers/perm...
lgtm
lgtm but do we understand why these tests passed before?
On 2016/11/23 at 20:40:46, reillyg wrote: > lgtm but do we understand why these tests passed before? Yes - the permission data that was actually tested was not retrieved from the app manifest data - it was created from the value passed into CreateTestApp. The app itself is only used to determine whether allow_usb_devices_permission_interface_class behavior feature is available (when creating check params).
The CQ bit was checked by lof84@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by lof84@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by lof84@yandex-team.ru
The CQ bit was checked by lof84@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by lof84@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479981932858640, "parent_rev":
"92eeea7822f42323c3ced8c23fbfe130adaeb1cb", "commit_rev":
"f7e443ae8b06f4a9c9a81e75bcf8559585e42090"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix USB device permissions tests BUG=629223 R=tbarzic, reillyg@chromium.org, meacer@chromium.org ========== to ========== Fix USB device permissions tests BUG=629223 R=tbarzic, reillyg@chromium.org, meacer@chromium.org Committed: https://crrev.com/438efe78ab6e2caa5d5a63967aea4b6544831dc8 Cr-Commit-Position: refs/heads/master@{#434312} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/438efe78ab6e2caa5d5a63967aea4b6544831dc8 Cr-Commit-Position: refs/heads/master@{#434312} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
