components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java - Issue 2515353005: [Android WebView] Implement copying and uploading of Minidumps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java

Issue 2515353005: [Android WebView] Implement copying and uploading of Minidumps. (Closed)

Patch Set: Fix findbugs errors for realz! Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java

diff --git a/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java b/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java

index b892cb8cdaf19a44f08d0d04b000f83e88b513d1..d4850376976da2835769edc3b97b5398e278dc05 100644

--- a/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java

+++ b/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java

@@ -92,7 +92,11 @@ public class MinidumpUploadCallableTest extends CrashTestCase {

}

- private static class TestHttpURLConnectionFactory implements HttpURLConnectionFactory {

+ /**

+ * A HttpURLConnectionFactory that performs some basic checks to ensure we are uploading

+ * minidumps correctly.

+ */

+ public static class TestHttpURLConnectionFactory implements HttpURLConnectionFactory {

@Override

public HttpURLConnection createHttpURLConnection(String url) {

try {