Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2515323002: VM: [Kernel] Cherry-pick from dart-lang/kernel_sdk (Closed)

Created:
4 years, 1 month ago by kustermann
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: [Kernel] Cherry-pick from dart-lang/kernel_sdk This is part of the following CL: Roll Kernel to fix an async bug. There was a bug in the translation of await in finally when there was a return in the try block. The new async/async* translation revealed a bug in the scoping of labels. Labels from enclosing functions were visible in nested functions. That bug is fixed here. Review URL: https://chromereviews.googleplex.com/536237014 . R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/c3895181a7c18885aeffaf890fbf068964b239bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -12 lines) Patch
M runtime/vm/kernel_binary.cc View 9 chunks +40 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
4 years, 1 month ago (2016-11-21 15:22:46 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 1 month ago (2016-11-21 15:27:59 UTC) #3
kustermann
4 years, 1 month ago (2016-11-21 15:49:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3895181a7c18885aeffaf890fbf068964b239bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698