Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2515303003: Move stuff from layoutBlockFlow() into new method addOverhangingFloatsFromChildren(). (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move stuff from layoutBlockFlow() into new method addOverhangingFloatsFromChildren(). + some cleanup in the vicinity. Committed: https://crrev.com/9c13e55b206dcb350fc6fe9e25c50f53a2934fbe Cr-Commit-Position: refs/heads/master@{#433886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -40 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +46 lines, -40 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-11-22 13:52:43 UTC) #4
szager1
lgtm
4 years, 1 month ago (2016-11-22 16:19:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515303003/1
4 years, 1 month ago (2016-11-22 16:45:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 16:51:55 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 16:55:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c13e55b206dcb350fc6fe9e25c50f53a2934fbe
Cr-Commit-Position: refs/heads/master@{#433886}

Powered by Google App Engine
This is Rietveld 408576698