Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: test/runner/engine_test.dart

Issue 2515303002: Add expectAsyncX and expectAsyncUntilX methods, and deprecate the old methods. (Closed)
Patch Set: Mark parameter types as Object. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/configuration/top_level_test.dart ('k') | test/runner/load_suite_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/engine_test.dart
diff --git a/test/runner/engine_test.dart b/test/runner/engine_test.dart
index 6ff680411b89d31a1a4a4068f306f8b371294f99..ffe900998b57e5e0daabd28c95244a9f35e978b8 100644
--- a/test/runner/engine_test.dart
+++ b/test/runner/engine_test.dart
@@ -16,7 +16,7 @@ void main() {
var testsRun = 0;
var tests = declare(() {
for (var i = 0; i < 4; i++) {
- test("test ${i + 1}", expectAsync(() {
+ test("test ${i + 1}", expectAsync0(() {
expect(testsRun, equals(i));
testsRun++;
}, max: 1));
@@ -36,7 +36,7 @@ void main() {
var testsRun = 0;
var tests = declare(() {
for (var i = 0; i < 4; i++) {
- test("test ${i + 1}", expectAsync(() {
+ test("test ${i + 1}", expectAsync0(() {
expect(testsRun, equals(i));
testsRun++;
}, max: 1));
@@ -57,11 +57,11 @@ void main() {
var testsRun = 0;
var engine = declareEngine(() {
for (var i = 0; i < 3; i++) {
- test("test ${i + 1}", expectAsync(() => testsRun++, max: 1));
+ test("test ${i + 1}", expectAsync0(() => testsRun++, max: 1));
}
});
- engine.onTestStarted.listen(expectAsync((liveTest) {
+ engine.onTestStarted.listen(expectAsync1((liveTest) {
// [testsRun] should be one less than the test currently running.
expect(liveTest.test.name, equals("test ${testsRun + 1}"));
@@ -117,7 +117,7 @@ void main() {
// than the inner test.
var secondTestStarted = false;
var firstTestFinished = false;
- var tearDownBody = expectAsync(() {
+ var tearDownBody = expectAsync0(() {
expect(secondTestStarted, isFalse);
expect(firstTestFinished, isFalse);
});
@@ -173,12 +173,12 @@ void main() {
var engine = new Engine.withSuites([runnerSuite(new Group.root(tests))]);
- engine.onTestStarted.listen(expectAsync((liveTest) {
+ engine.onTestStarted.listen(expectAsync1((liveTest) {
expect(liveTest, same(engine.liveTests.single));
expect(liveTest.test.name, equals(tests.single.name));
var i = 0;
- liveTest.onStateChange.listen(expectAsync((state) {
+ liveTest.onStateChange.listen(expectAsync1((state) {
if (i == 0) {
expect(state, equals(const State(Status.running, Result.success)));
} else if (i == 1) {
@@ -231,12 +231,12 @@ void main() {
var engine = new Engine.withSuites(
[runnerSuite(new Group.root(entries))]);
- engine.onTestStarted.listen(expectAsync((liveTest) {
+ engine.onTestStarted.listen(expectAsync1((liveTest) {
expect(liveTest, same(engine.liveTests.single));
expect(liveTest.test.name, equals("group test"));
var i = 0;
- liveTest.onStateChange.listen(expectAsync((state) {
+ liveTest.onStateChange.listen(expectAsync1((state) {
if (i == 0) {
expect(state, equals(const State(Status.running, Result.success)));
} else if (i == 1) {
« no previous file with comments | « test/runner/configuration/top_level_test.dart ('k') | test/runner/load_suite_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698