Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/gn/operators.cc

Issue 25153002: Enable compiling GN by default. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set:  Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/standard_out.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/operators.cc
diff --git a/tools/gn/operators.cc b/tools/gn/operators.cc
index 0e91f6b7b40bc36397d03eaa73dfd8bd614eaa2f..f2b0415889b01a2c39f8b7d8c22453a43f863c55 100644
--- a/tools/gn/operators.cc
+++ b/tools/gn/operators.cc
@@ -127,11 +127,13 @@ Value ExecuteEquals(Scope* scope,
!right.list_value().empty()) {
*err = Err(op_node->left()->GetRange(), "Replacing nonempty list.",
std::string("This overwrites a previously-defined nonempty list ") +
- "(length " + base::IntToString(old_value->list_value().size()) +
- ").");
+ "(length " +
+ base::IntToString(static_cast<int>(old_value->list_value().size()))
+ + ").");
err->AppendSubErr(Err(*old_value, "for previous definition",
"with another one (length " +
- base::IntToString(right.list_value().size()) + "). Did you mean " +
+ base::IntToString(static_cast<int>(right.list_value().size())) +
+ "). Did you mean " +
"\"+=\" to append instead? If you\nreally want to do this, do\n " +
left.value().as_string() + " = []\nbefore reassigning."));
return Value();
« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/standard_out.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698