Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2515253007: Mac: Fix compilation against the 10.12.1 SDK. (Closed)

Created:
4 years ago by tapted
Modified:
4 years ago
Reviewers:
Sidney San Martín
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix compilation against the 10.12.1 SDK. r433558 introduced a compile regression which bots and users of the hermetic toolchain are insulated from. It deleted forward class declarations required to suppress limited availability warnings when compiling against the 10.12.1 SDK. BUG=666893 TBR=sdy@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/base/cocoa/touch_bar_forward_declarations.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (7 generated)
tapted
Description was changed from ========== whitespace fixee BUG= ========== to ========== Mac: Fix compilation against ...
4 years ago (2016-11-23 05:01:23 UTC) #1
tapted
tapted@chromium.org changed reviewers: + sdy@chromium.org
4 years ago (2016-11-23 05:01:24 UTC) #2
tapted
Description was changed from ========== Mac: Fix compilation against the 10.12.1 SDK. r433558 introduced a ...
4 years ago (2016-11-23 05:01:59 UTC) #3
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years ago (2016-11-23 05:02:11 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515253007/1
4 years ago (2016-11-23 05:02:28 UTC) #5
tapted
Description was changed from ========== Mac: Fix compilation against the 10.12.1 SDK. r433558 introduced a ...
4 years ago (2016-11-23 05:03:45 UTC) #6
tapted
4 years ago (2016-11-23 05:04:27 UTC) #7
Description was changed from

==========
Mac: Fix compilation against the 10.12.1 SDK.

r433558 introduced a compile regression which internal builders and
users of the hermetic toolchain are insulated from. It deleted forward
class declarations required to suppress limited availability warnings
when compiling against the 10.12.1 SDK.

BUG=666893
TBR=sdy@chromium.org
==========

to

==========
Mac: Fix compilation against the 10.12.1 SDK.

r433558 introduced a compile regression which bots and users of the
hermetic toolchain are insulated from. It deleted forward class
declarations required to suppress limited availability warnings when
compiling against the 10.12.1 SDK.

BUG=666893
TBR=sdy@chromium.org
==========

Powered by Google App Engine
This is Rietveld 408576698