Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2515233004: Make OnWmDisplayRemoved() take a WindowTreeHost (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make OnWmDisplayRemoved() take a WindowTreeHost BUG=664625 TEST=none R=msw@chromium.org TBR=msw@chromium.org Committed: https://crrev.com/d78075be67a3ee6520d1f8377cd69b478ebdf5ee Cr-Commit-Position: refs/heads/master@{#434071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M ui/aura/mus/window_manager_delegate.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/aura_test_base.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
I'm TBRing as this comes from https://codereview.chromium.org/2500973002/ , which you already reviewed. I'm landing separately ...
4 years ago (2016-11-22 23:28:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515233004/1
4 years ago (2016-11-22 23:28:58 UTC) #3
msw
I guess you just split out part of <http://codereview.chromium.org/2500973002>? Anyways, lgtm
4 years ago (2016-11-23 00:06:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 01:24:55 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-23 01:28:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d78075be67a3ee6520d1f8377cd69b478ebdf5ee
Cr-Commit-Position: refs/heads/master@{#434071}

Powered by Google App Engine
This is Rietveld 408576698