Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2515233002: [ic] Remove names table from type feedback metadata. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Remove names table from type feedback metadata. BUG=chromium:576312, v8:5561 Committed: https://crrev.com/7d61ddfa912cd2c9f219054b076d895638cb6147 Cr-Commit-Position: refs/heads/master@{#41130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -135 lines) Patch
M src/ast/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/object-stats.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +1 line, -12 lines 0 comments Download
M src/type-feedback-vector.h View 11 chunks +4 lines, -41 lines 0 comments Download
M src/type-feedback-vector.cc View 6 chunks +0 lines, -51 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-21 09:56:00 UTC) #4
mvstanton
lgtm
4 years, 1 month ago (2016-11-21 10:01:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515233002/1
4 years, 1 month ago (2016-11-21 10:34:09 UTC) #9
ulan
heap lgtm
4 years, 1 month ago (2016-11-21 10:35:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515233002/1
4 years, 1 month ago (2016-11-21 10:36:10 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28955)
4 years, 1 month ago (2016-11-21 10:39:10 UTC) #16
Toon Verwaest
lgtm
4 years, 1 month ago (2016-11-21 10:44:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515233002/1
4 years, 1 month ago (2016-11-21 10:44:09 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 10:45:49 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 10:46:30 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d61ddfa912cd2c9f219054b076d895638cb6147
Cr-Commit-Position: refs/heads/master@{#41130}

Powered by Google App Engine
This is Rietveld 408576698