DevTools: cleanup breakpointManager after removal of NetworkMapping

third_party/WebKit/Source/devtools/front_end/common/Settings.js

Index: third_party/WebKit/Source/devtools/front_end/common/Settings.js
diff --git a/third_party/WebKit/Source/devtools/front_end/common/Settings.js b/third_party/WebKit/Source/devtools/front_end/common/Settings.js
index 1eb30e04d50b4d922a26a1f38976da4c14e2f5fb..400f2e27abc37686d1575d0f391044ae5005e57b 100644
--- a/third_party/WebKit/Source/devtools/front_end/common/Settings.js
+++ b/third_party/WebKit/Source/devtools/front_end/common/Settings.js
@@ -699,6 +699,18 @@ Common.VersionController = class {
     networkColumns.set(columns);
   }
 
+  _updateVersionFrom21To22() {
+    var breakpointsSetting = Common.settings.createLocalSetting('breakpoints', []);
+    var breakpoints = breakpointsSetting.get();
+    for (var breakpoint of breakpoints) {
+      if (breakpoint.sourceFileId && !breakpoint.url) {
+        breakpoint.url = breakpoint.sourceFileId;

[dgozman, 2016/11/22 01:44:41]

Don't you want to always set an url? Or it could be missing?

breakpoint.url = breakpoint.sourceFileId || '';

[lushnikov, 2016/11/22 02:09:46]

Agreed. I always want this.

+        delete breakpoint.sourceFileId;
+      }
+    }
+    breakpointsSetting.set(breakpoints);
+  }
+
   _migrateSettingsFromLocalStorage() {
     // This step migrates all the settings except for the ones below into the browser profile.
     var localSettings = new Set([
@@ -731,7 +743,7 @@ Common.VersionController = class {
 };
 
 Common.VersionController._currentVersionName = 'inspectorVersion';
-Common.VersionController.currentVersion = 21;
+Common.VersionController.currentVersion = 22;
 
 /**
  * @type {!Common.Settings}