DevTools: cleanup breakpointManager after removal of NetworkMapping

third_party/WebKit/Source/devtools/front_end/common/Settings.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 681 matching lines @@
   }
 
   _updateVersionFrom20To21() {
     var networkColumns = Common.settings.createSetting('networkLogColumns', {});
     var columns = /** @type {!Object} */ (networkColumns.get());
     delete columns['timeline'];
     delete columns['waterfall'];
     networkColumns.set(columns);
   }
 
+  _updateVersionFrom21To22() {
+    var breakpointsSetting = Common.settings.createLocalSetting('breakpoints', []);
+    var breakpoints = breakpointsSetting.get();
+    for (var breakpoint of breakpoints) {
+      if (breakpoint.sourceFileId && !breakpoint.url) {
+        breakpoint.url = breakpoint.sourceFileId;

[dgozman, 2016/11/22 01:44:41]

Don't you want to always set an url? Or it could be missing?

breakpoint.url = breakpoint.sourceFileId || '';

[lushnikov, 2016/11/22 02:09:46]

Agreed. I always want this.

+        delete breakpoint.sourceFileId;
+      }
+    }
+    breakpointsSetting.set(breakpoints);
+  }
+
   _migrateSettingsFromLocalStorage() {
     // This step migrates all the settings except for the ones below into the browser profile.
     var localSettings = new Set([
       'advancedSearchConfig', 'breakpoints', 'consoleHistory', 'domBreakpoints', 'eventListenerBreakpoints',
       'fileSystemMapping', 'lastSelectedSourcesSidebarPaneTab', 'previouslyViewedFiles', 'savedURLs',
       'watchExpressions', 'workspaceExcludedFolders', 'xhrBreakpoints'
     ]);
     if (!window.localStorage)
       return;
 
@@ skipping 12 matching lines @@
    */
   _clearBreakpointsWhenTooMany(breakpointsSetting, maxBreakpointsCount) {
     // If there are too many breakpoints in a storage, it is likely due to a recent bug that caused
     // periodical breakpoints duplication leading to inspector slowness.
     if (breakpointsSetting.get().length > maxBreakpointsCount)
       breakpointsSetting.set([]);
   }
 };
 
 Common.VersionController._currentVersionName = 'inspectorVersion';
-Common.VersionController.currentVersion = 21;
+Common.VersionController.currentVersion = 22;
 
 /**
  * @type {!Common.Settings}
  */
 Common.settings;
 
 /**
  * @param {string} settingName
  * @return {!Common.Setting}
  */
 Common.moduleSetting = function(settingName) {
   return Common.settings.moduleSetting(settingName);
 };
 
 /**
  * @param {string} settingName
  * @return {!Common.Setting}
  */
 Common.settingForTest = function(settingName) {
   return Common.settings.settingForTest(settingName);
 };