WTF: Remove NO_RETURN, NO_RETURN_DUE_TO_CRASH, and NO_RETURN_DUE_TO_ASSERT.

WTF: Remove NO_RETURN, NO_RETURN_DUE_TO_CRASH, and NO_RETURN_DUE_TO_ASSERT.

There are only two instances of NO_RETURN_DUE_TO_ASSERT in Mac-only code.
Remove them for simplicity.

BUG=596760
Committed: https://crrev.com/d0d60458381abc2d150df4c505d4b857c6f83783
Cr-Commit-Position: refs/heads/master@{#433534}

[tkent, 2016-11-21 06:20:52]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 06:20:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-11-21 08:14:58]

tkent@chromium.org changed reviewers:
+ yutak@chromium.org

[tkent, 2016-11-21 08:14:58]

yutak@, would you review this please?

[commit-bot: I haz the power, 2016-11-21 08:16:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 08:16:57]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2016-11-21 08:55:21]

LGTM (but see notes below)

https://codereview.chromium.org/2515213002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/Compiler.h (left):

https://codereview.chromium.org/2515213002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Compiler.h:66: #ifndef NO_RETURN
I was initially a bit hesitant to remove this, because noreturn has some
performance benefits (compilers are able to skip saving the register
values, etc.).

However, I start to think it's okay to remove this and the use sites in
Blink for now, because:
(1) C++11 has a standard way of writing this: [[noreturn]]
    http://en.cppreference.com/w/cpp/language/attributes
(2) All the use sites do not seem performance sensitive.

[tkent, 2016-11-21 14:16:51]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-11-21 14:17:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 14:21:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479737811268920, "parent_rev":
["2551d891ed994d68f33f5abc2b702a1be990dd82", null], "commit_rev":
["9c96e0dc2462094fb71f2678ff16ae2b8fc6fbb8", null]}

[commit-bot: I haz the power, 2016-11-21 14:21:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-21 14:25:09]

Description was changed from

==========
WTF: Remove NO_RETURN, NO_RETURN_DUE_TO_CRASH, and NO_RETURN_DUE_TO_ASSERT.

There are only two instances of NO_RETURN_DUE_TO_ASSERT in Mac-only code.
Remove them for simplicity.

BUG=596760
==========

to

==========
WTF: Remove NO_RETURN, NO_RETURN_DUE_TO_CRASH, and NO_RETURN_DUE_TO_ASSERT.

There are only two instances of NO_RETURN_DUE_TO_ASSERT in Mac-only code.
Remove them for simplicity.

BUG=596760

Committed: https://crrev.com/d0d60458381abc2d150df4c505d4b857c6f83783
Cr-Commit-Position: refs/heads/master@{#433534}
==========

[commit-bot: I haz the power, 2016-11-21 14:25:10]

Patchset 1 (id:??) landed as
https://crrev.com/d0d60458381abc2d150df4c505d4b857c6f83783
Cr-Commit-Position: refs/heads/master@{#433534}