Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2515043002: Mojo EDK: Fix race in named pipe creation for tests (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
Reviewers:
Sam McNally
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo EDK: Fix race in named pipe creation for tests This ensures named pipes are created before child process launch, addressing a potential race where a child can attempt to connect before a socket/handle is bound to the pipe path by the server process. BUG=666356 R=sammc@chromium.org Committed: https://crrev.com/f39ddac7b3677fc425fc89beba67000b59cbb9ad Cr-Commit-Position: refs/heads/master@{#433464}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M mojo/edk/test/multiprocess_test_helper.cc View 2 chunks +18 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Ken Rockot(use gerrit already)
I think this will likely fix the hangs on Android tests. I can repro hangs ...
4 years, 1 month ago (2016-11-19 01:36:59 UTC) #6
Sam McNally
lgtm
4 years, 1 month ago (2016-11-20 23:03:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515043002/20001
4 years, 1 month ago (2016-11-20 23:17:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-21 00:07:38 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 00:10:00 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f39ddac7b3677fc425fc89beba67000b59cbb9ad
Cr-Commit-Position: refs/heads/master@{#433464}

Powered by Google App Engine
This is Rietveld 408576698