Whitelist the Hotword extension.

Whitelist the Hotword extension.
The Hotword extension relies on other means to communicate usage of the microphone. See details in issue.

BUG=360662
TEST=Due to issues with the extension's use of WebAudio and recent changes in Blink, the functionality of the extension can't be easily verified but I verified via the debug console that the extension successfully completes a getUserMedia call and the system tray icon isn't shown (due to the whitelist).
R=xians@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266359

[tommi (sloooow) - chröme, 2014-04-24 20:59:23]

Fix whitespace

[tommi (sloooow) - chröme, 2014-04-24 21:17:22]

Fix android build error

[no longer working on chromium, 2014-04-25 11:19:34]

lgtm with a few nits, please address them.

https://codereview.chromium.org/251503003/diff/40001/chrome/browser/media/med...
File chrome/browser/media/media_stream_capture_indicator.cc (right):

https://codereview.chromium.org/251503003/diff/40001/chrome/browser/media/med...
chrome/browser/media/media_stream_capture_indicator.cc:66: static const char*
kExtensionWhitelist[] = {
nit, static const char* const ?

https://codereview.chromium.org/251503003/diff/40001/chrome/browser/media/med...
chrome/browser/media/media_stream_capture_indicator.cc:78: #endif  // 
!defined(OS_ANDROID)
nit, one empty space between // and !defined(OS_ANDROID)

https://codereview.chromium.org/251503003/diff/40001/chrome/browser/media/med...
chrome/browser/media/media_stream_capture_indicator.cc:433: // Audio/video icon
is shown only for extensions or on Android.
could you please update the comment to explain we do not show the icon for the
whitelisted extension(s) ?

[tommi (sloooow) - chröme, 2014-04-25 14:53:07]

Address comments

[tommi (sloooow) - chröme, 2014-04-25 14:53:50]

https://codereview.chromium.org/251503003/diff/40001/chrome/browser/media/med...
File chrome/browser/media/media_stream_capture_indicator.cc (right):

https://codereview.chromium.org/251503003/diff/40001/chrome/browser/media/med...
chrome/browser/media/media_stream_capture_indicator.cc:66: static const char*
kExtensionWhitelist[] = {
On 2014/04/25 11:19:34, xians1 wrote:
> nit, static const char* const ?

Done.

https://codereview.chromium.org/251503003/diff/40001/chrome/browser/media/med...
chrome/browser/media/media_stream_capture_indicator.cc:78: #endif  // 
!defined(OS_ANDROID)
On 2014/04/25 11:19:34, xians1 wrote:
> nit, one empty space between // and !defined(OS_ANDROID)

Done.

https://codereview.chromium.org/251503003/diff/40001/chrome/browser/media/med...
chrome/browser/media/media_stream_capture_indicator.cc:433: // Audio/video icon
is shown only for extensions or on Android.
On 2014/04/25 11:19:34, xians1 wrote:
> could you please update the comment to explain we do not show the icon for the
> whitelisted extension(s) ?

Done.

[tommi (sloooow) - chröme, 2014-04-25 14:53:53]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:17:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommi@chromium.org/251503003/60001

[commit-bot: I haz the power, 2014-04-25 23:49:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:49:59]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[tommi (sloooow) - chröme, 2014-04-26 05:36:47]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2014-04-26 05:37:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommi@chromium.org/251503003/60001

[tommi (sloooow) - chröme, 2014-04-26 10:24:35]

Committed patchset #4 manually as r266359 (presubmit successful).