[wasm] Throw a RangeError if Wasm memory could not be allocated.

[wasm] Throw a RangeError if Wasm memory could not be allocated.

This fixes a bug found by the fuzzer where we would attempt to
dereference a null handle if memory allocation failed. In this case,
the failure was because the amount of memory requested was above V8's
hardcoded limit.

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=666741

Committed: https://crrev.com/d0fe942d2304655f587f49a0b6a1c9a079692912
Cr-Commit-Position: refs/heads/master@{#41158}

[Eric Holk, 2016-11-18 21:28:03]

eholk@chromium.org changed reviewers:
+ bradnelson@chromium.org, gdeepti@chromium.org, mtrofin@google.com,
titzer@chromium.org

[Eric Holk, 2016-11-18 23:09:14]

The CQ bit was checked by eholk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 23:09:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-11-18 23:19:29]

lgtm with nit

https://codereview.chromium.org/2514983002/diff/1/test/mjsunit/regress/wasm/r...
File test/mjsunit/regress/wasm/regression-666741.js (right):

https://codereview.chromium.org/2514983002/diff/1/test/mjsunit/regress/wasm/r...
test/mjsunit/regress/wasm/regression-666741.js:8: try {
You can use one of the assertThrows() helper functions here I think.

[commit-bot: I haz the power, 2016-11-19 00:02:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 00:02:17]

Dry run: This issue passed the CQ dry run.

[Eric Holk, 2016-11-21 21:15:15]

https://codereview.chromium.org/2514983002/diff/1/test/mjsunit/regress/wasm/r...
File test/mjsunit/regress/wasm/regression-666741.js (right):

https://codereview.chromium.org/2514983002/diff/1/test/mjsunit/regress/wasm/r...
test/mjsunit/regress/wasm/regression-666741.js:8: try {
On 2016/11/18 23:19:29, titzer wrote:
> You can use one of the assertThrows() helper functions here I think.

Done.

I didn't use assertThrows originally because I wanted to test the behavior that
if WebAssembly.Memory throws, it throws a RangeError, without requiring it to
throw. I don't think there's anything in the WebAssembly spec to require failure
here, it's just a quirk of V8's implementation. It'll be easy enough to fix in
the future if we remove this restriction though.

[Eric Holk, 2016-11-21 21:15:22]

The CQ bit was checked by eholk@chromium.org

[Eric Holk, 2016-11-21 21:15:22]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2514983002/#ps40001
(title: "Fixing nits")

[commit-bot: I haz the power, 2016-11-21 21:15:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 21:58:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479762922176430,
"parent_rev": "d4d8c3248e430a5b1d36132bbaa698ca9aee4fd6", "commit_rev":
"1ecbefb44d195f2a0abaeef7420e4e4324c61ef0"}

[commit-bot: I haz the power, 2016-11-21 21:58:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-21 21:59:00]

Description was changed from

==========
[wasm] Throw a RangeError if Wasm memory could not be allocated.

This fixes a bug found by the fuzzer where we would attempt to
dereference a null handle if memory allocation failed. In this case,
the failure was because the amount of memory requested was above V8's
hardcoded limit.

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=666741
==========

to

==========
[wasm] Throw a RangeError if Wasm memory could not be allocated.

This fixes a bug found by the fuzzer where we would attempt to
dereference a null handle if memory allocation failed. In this case,
the failure was because the amount of memory requested was above V8's
hardcoded limit.

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=666741

Committed: https://crrev.com/d0fe942d2304655f587f49a0b6a1c9a079692912
Cr-Commit-Position: refs/heads/master@{#41158}
==========

[commit-bot: I haz the power, 2016-11-21 21:59:01]

Patchset 3 (id:??) landed as
https://crrev.com/d0fe942d2304655f587f49a0b6a1c9a079692912
Cr-Commit-Position: refs/heads/master@{#41158}