DevTools: enable target domain handler on the browser target, make browser target non-discoverable.

DevTools: enable target domain handler on the browser target, make browser target non-discoverable.

BUG=666865

[pfeldman, 2016-11-18 22:57:39]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-11-18 23:25:57]

https://codereview.chromium.org/2514933003/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_http_handler.cc (right):

https://codereview.chromium.org/2514933003/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_http_handler.cc:659: browser_prefix =
browser_prefix + "/" + browser_guid;
This breaks tethering which tries to communicate over /devtools/browser. See
port_forwarding_controller.cc.

[dgozman, 2016-11-18 23:41:55]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-11-18 23:41:55]

lgtm

[commit-bot: I haz the power, 2016-11-18 23:43:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 01:15:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 01:15:09]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-11-21 19:38:25]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-11-21 19:38:26]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2514933003/#ps40001
(title: "port forwarding test fixed")

[commit-bot: I haz the power, 2016-11-21 19:39:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 19:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:43:02]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-11-21 20:10:30]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-11-21 20:10:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2514933003/#ps60001
(title: "rebaselined")

[commit-bot: I haz the power, 2016-11-21 20:11:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 21:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 21:47:29]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nednguyen, 2016-11-30 22:36:58]

On 2016/11/21 21:47:29, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Upon launching the browser, Telemetry makes a GET request to
"127.0.0.1:<devtool_port>/json/" to check whether it can establish a connection
with devtool. How does this CL change it?

[nednguyen, 2016-11-30 22:37:09]

Description was changed from

==========
DevTools: enable target domain handler on the browser target, make browser
target non-discoverable.

BUG=666865
==========

to

==========
DevTools: enable target domain handler on the browser target, make browser
target non-discoverable.

BUG=666865
==========

[nednguyen, 2016-11-30 22:37:09]

nednguyen@google.com changed reviewers:
+ nednguyen@google.com

[pfeldman, 2016-11-30 22:49:07]

It does not change it, it only removes the 127.0.0.1:<devtool_port>/browser/
endpoint. Do you see from the logs that it can't establish the /json connection?
Could you do me a favor and tell me what I should run locally to repro?

[nednguyen, 2016-11-30 22:55:48]

On 2016/11/30 22:49:07, pfeldman wrote:
> It does not change it, it only removes the 127.0.0.1:<devtool_port>/browser/
> endpoint. Do you see from the logs that it can't establish the /json
connection?
> Could you do me a favor and tell me what I should run locally to repro?

You can run:
src/tools/perf/run_telemetry_tests --browser=release testBrowserCreation to
repro

[pfeldman, 2017-02-17 18:19:19]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 18:19:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 19:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 19:49:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2017-03-02 23:17:04]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 23:17:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 00:55:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 00:55:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2017-07-15 05:46:08]

dgozman@chromium.org changed reviewers:
- dgozman@chromium.org