Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2514933002: EME: Update MediaKeyMessageEvent to match spec (Closed)

Created:
4 years, 1 month ago by jrummell
Modified:
4 years, 1 month ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, haraken, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EME: Update MediaKeyMessageEvent to match spec MediaKeyMessageEventInit is now required for the constructor. BUG=666869 TEST=W3C EME test mentioned in the bug no longer fails. Committed: https://crrev.com/23ca36ab9e996dfad12a6bd21346208c56f918d0 Cr-Commit-Position: refs/heads/master@{#433323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeyMessageEvent.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
jrummell
PTAL
4 years, 1 month ago (2016-11-18 20:53:31 UTC) #3
ddorwin
In the TEST line of the description, s/asserts/fails/. Also, you might say, "The test in ...
4 years, 1 month ago (2016-11-18 21:02:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514933002/1
4 years, 1 month ago (2016-11-18 22:49:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 23:04:04 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 23:06:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23ca36ab9e996dfad12a6bd21346208c56f918d0
Cr-Commit-Position: refs/heads/master@{#433323}

Powered by Google App Engine
This is Rietveld 408576698