Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 251493003: Update the number of test folders after bug fixed (Closed)

Created:
6 years, 8 months ago by ltilve
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tzik, Lei Zhang, nhiroki, tommycli, Greg Billock, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update the number of test folders after bug fixed As the flakiness on the temporary random directories creation was solved by using base::rand_util on crrev.com/15479003, the number of folders can be increased back. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ltilve
There was a TODO requesting to increase the number of folders when the fix at ...
6 years, 8 months ago (2014-04-24 09:22:11 UTC) #1
tommycli
lgtm Thanks for the fix! Feel free to put "TBR=thestig" as a new line in ...
6 years, 8 months ago (2014-04-24 21:39:26 UTC) #2
vandebo (ex-Chrome)
LGTM
6 years, 8 months ago (2014-04-24 21:42:46 UTC) #3
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 8 months ago (2014-04-24 21:43:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ltilve@igalia.com/251493003/1
6 years, 8 months ago (2014-04-24 22:01:59 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 02:30:48 UTC) #6
Message was sent while issue was closed.
Change committed as 266088

Powered by Google App Engine
This is Rietveld 408576698