ui/events/cocoa/cocoa_event_utils.mm - Issue 251493002: MacViews: Implement basic NSEvent -> ui::Event conversion for Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/cocoa/cocoa_event_utils.mm

Issue 251493002: MacViews: Implement basic NSEvent -> ui::Event conversion for Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/cocoa/cocoa_event_utils.mm

diff --git a/ui/events/cocoa/cocoa_event_utils.mm b/ui/events/cocoa/cocoa_event_utils.mm

index dd3984522ba7914b7306c3f9a458d230927f5972..ade083c0eb24547d7f7d1f8b6ad2f82c0ed0f1b8 100644

--- a/ui/events/cocoa/cocoa_event_utils.mm

+++ b/ui/events/cocoa/cocoa_event_utils.mm

@@ -34,11 +34,6 @@ bool IsMiddleButtonEvent(NSEvent* event) {

namespace ui {

-int EventFlagsFromNative(const base::NativeEvent& event) {

- NSUInteger modifiers = [event modifierFlags];

- return EventFlagsFromNSEventWithModifiers(event, modifiers);

int EventFlagsFromModifiers(NSUInteger modifiers) {

int flags = 0;

flags |= (modifiers & NSAlphaShiftKeyMask) ? ui::EF_CAPS_LOCK_DOWN : 0;

« no previous file with comments | « no previous file | ui/events/cocoa/cocoa_event_utils_unittest.mm » ('j') | no next file with comments »