Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2514893004: DevTools: show array entries that are getters (Closed)
Patch Set: Add needsManualRebase to TE Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 769 matching lines...) Expand 10 before | Expand all | Expand 10 after
780 continue; // Only render name once in the given continuous block. 780 continue; // Only render name once in the given continuous block.
781 if (renderedNameCount) 781 if (renderedNameCount)
782 widget.createTextChild(', '); 782 widget.createTextChild(', ');
783 var nameValuePair = widget.createChild('span'); 783 var nameValuePair = widget.createChild('span');
784 widget.__nameToToken.set(name, nameValuePair); 784 widget.__nameToToken.set(name, nameValuePair);
785 nameValuePair.createTextChild(name + ' = '); 785 nameValuePair.createTextChild(name + ' = ');
786 var value = valuesMap.get(name); 786 var value = valuesMap.get(name);
787 var propertyCount = value.preview ? value.preview.properties.length : 0; 787 var propertyCount = value.preview ? value.preview.properties.length : 0;
788 var entryCount = value.preview && value.preview.entries ? value.preview. entries.length : 0; 788 var entryCount = value.preview && value.preview.entries ? value.preview. entries.length : 0;
789 if (value.preview && propertyCount + entryCount < 10) 789 if (value.preview && propertyCount + entryCount < 10)
790 formatter.appendObjectPreview(nameValuePair, value.preview); 790 formatter.appendObjectPreview(nameValuePair, value.preview, value);
791 else 791 else
792 nameValuePair.appendChild(Components.ObjectPropertiesSection.createVal ueElement(value, false)); 792 nameValuePair.appendChild(Components.ObjectPropertiesSection.createVal ueElement(value, false));
793 ++renderedNameCount; 793 ++renderedNameCount;
794 } 794 }
795 795
796 var widgetChanged = true; 796 var widgetChanged = true;
797 if (oldWidget) { 797 if (oldWidget) {
798 widgetChanged = false; 798 widgetChanged = false;
799 for (var name of widget.__nameToToken.keys()) { 799 for (var name of widget.__nameToToken.keys()) {
800 var oldText = oldWidget.__nameToToken.get(name) ? oldWidget.__nameToTo ken.get(name).textContent : ''; 800 var oldText = oldWidget.__nameToToken.get(name) ? oldWidget.__nameToTo ken.get(name).textContent : '';
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
1124 Workspace.UISourceCode.Events.WorkingCopyChanged, this._workingCopyChang ed, this); 1124 Workspace.UISourceCode.Events.WorkingCopyChanged, this._workingCopyChang ed, this);
1125 this.uiSourceCode().removeEventListener( 1125 this.uiSourceCode().removeEventListener(
1126 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._workingCopyCom mitted, this); 1126 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._workingCopyCom mitted, this);
1127 this.uiSourceCode().removeEventListener( 1127 this.uiSourceCode().removeEventListener(
1128 Workspace.UISourceCode.Events.TitleChanged, this._showBlackboxInfobarIfN eeded, this); 1128 Workspace.UISourceCode.Events.TitleChanged, this._showBlackboxInfobarIfN eeded, this);
1129 Common.moduleSetting('skipStackFramesPattern').removeChangeListener(this._sh owBlackboxInfobarIfNeeded, this); 1129 Common.moduleSetting('skipStackFramesPattern').removeChangeListener(this._sh owBlackboxInfobarIfNeeded, this);
1130 Common.moduleSetting('skipContentScripts').removeChangeListener(this._showBl ackboxInfobarIfNeeded, this); 1130 Common.moduleSetting('skipContentScripts').removeChangeListener(this._showBl ackboxInfobarIfNeeded, this);
1131 super.dispose(); 1131 super.dispose();
1132 } 1132 }
1133 }; 1133 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698