Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2514893002: Fix function name inference corruption for async functions (Closed)

Created:
4 years, 1 month ago by Dan Ehrenberg
Modified:
4 years, 1 month ago
Reviewers:
gsathya, caitp, marja
CC:
v8-reviews_googlegroups.com, adamk, marja
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix function name inference corruption for async functions The code which pushes and pops to the function name inference stack generally checks if the stack is active with the IsOpen method. One piece of code pertaining to async functions was missing that check. This patch adds it. BUG=chromium:658267 R=gsathya,caitp Committed: https://crrev.com/06f8e877267c9acae10e53e3054bea209dc92b78 Cr-Commit-Position: refs/heads/master@{#41120}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/parsing/func-name-inferrer.cc View 1 chunk +5 lines, -3 lines 1 comment Download
A test/mjsunit/regress/regress-cr-658267.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Dan Ehrenberg
4 years, 1 month ago (2016-11-18 17:16:13 UTC) #3
caitp
https://codereview.chromium.org/2514893002/diff/1/src/parsing/func-name-inferrer.cc File src/parsing/func-name-inferrer.cc (right): https://codereview.chromium.org/2514893002/diff/1/src/parsing/func-name-inferrer.cc#newcode48 src/parsing/func-name-inferrer.cc:48: if (IsOpen()) { I like the straight forward fix, ...
4 years, 1 month ago (2016-11-18 17:18:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514893002/1
4 years, 1 month ago (2016-11-18 17:19:56 UTC) #7
marja
lgtm (looks like i don't have access to the bug - weird!)
4 years, 1 month ago (2016-11-18 18:28:43 UTC) #10
marja
lgtm (looks like i don't have access to the bug - weird!)
4 years, 1 month ago (2016-11-18 18:28:47 UTC) #11
marja
lgtm (looks like i don't have access to the bug - weird!)
4 years, 1 month ago (2016-11-18 18:28:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514893002/1
4 years, 1 month ago (2016-11-18 18:29:34 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 18:31:38 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 18:32:12 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06f8e877267c9acae10e53e3054bea209dc92b78
Cr-Commit-Position: refs/heads/master@{#41120}

Powered by Google App Engine
This is Rietveld 408576698