Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2514873002: [ObjC ARC] Converts ios/chrome/browser/ui/voice:voice to ARC.Automatically generated ARCMigrate c… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/voice:voice to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/d9336f6b8b9175ddf58418d450119b1017499fd0 Cr-Commit-Position: refs/heads/master@{#433523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ios/chrome/browser/ui/voice/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/voice/text_to_speech_player.mm View 3 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/voice/voice_search_notification_names.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-18 18:23:41 UTC) #4
kkhorimoto
lgtm
4 years, 1 month ago (2016-11-18 19:01:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514873002/1
4 years, 1 month ago (2016-11-21 12:21:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 13:35:27 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 13:37:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9336f6b8b9175ddf58418d450119b1017499fd0
Cr-Commit-Position: refs/heads/master@{#433523}

Powered by Google App Engine
This is Rietveld 408576698