Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2514853002: [ObjC ARC] Converts ios/chrome/browser/ui/keyboard:keyboard to ARC.Automatically generated ARCMig… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/keyboard:keyboard to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/d072454220f95afb61178ee1a73516bc90436bf1 Cr-Commit-Position: refs/heads/master@{#433907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M ios/chrome/browser/ui/keyboard/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/keyboard/UIKeyCommand+Chrome.mm View 1 chunk +6 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/keyboard/hardware_keyboard_watcher.mm View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 13:06:45 UTC) #6
noyau (Ping after 24h)
lgtm
4 years, 1 month ago (2016-11-21 14:27:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514853002/1
4 years, 1 month ago (2016-11-21 15:40:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/276883)
4 years, 1 month ago (2016-11-21 19:43:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514853002/1
4 years, 1 month ago (2016-11-22 14:24:10 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 17:43:40 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 17:45:37 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d072454220f95afb61178ee1a73516bc90436bf1
Cr-Commit-Position: refs/heads/master@{#433907}

Powered by Google App Engine
This is Rietveld 408576698