Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 2514843002: [ObjC ARC] Converts ios/chrome/browser/ui/alert_coordinator:unit_tests to ARC.Automatically gener… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
Reviewers:
gambard, sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/alert_coordinator:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/b349fb9751cd9f6b2667db7819e5f6c8c9254faf Cr-Commit-Position: refs/heads/master@{#436306}

Patch Set 1 #

Patch Set 2 : removed scoped_nsobject #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -41 lines) Patch
M ios/chrome/browser/ui/alert_coordinator/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator_unittest.mm View 1 chunk +14 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm View 1 4 chunks +17 lines, -17 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/input_alert_coordinator_unittest.mm View 2 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 33 (18 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 12:26:01 UTC) #6
gambard
lgtm
4 years, 1 month ago (2016-11-21 12:41:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514843002/1
4 years, 1 month ago (2016-11-21 13:12:07 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-21 13:12:08 UTC) #11
stkhapugin
+sdefresne as committer
4 years, 1 month ago (2016-11-21 15:44:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514843002/1
4 years, 1 month ago (2016-11-21 15:44:31 UTC) #15
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-21 15:44:32 UTC) #17
sdefresne
lgtm
4 years, 1 month ago (2016-11-21 15:45:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514843002/1
4 years, 1 month ago (2016-11-21 17:05:22 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/276943)
4 years, 1 month ago (2016-11-21 21:08:29 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514843002/1
4 years ago (2016-11-24 12:53:41 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/304136)
4 years ago (2016-11-24 15:20:37 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514843002/20001
4 years ago (2016-12-05 15:11:36 UTC) #29
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 16:12:34 UTC) #31
commit-bot: I haz the power
4 years ago (2016-12-05 16:14:54 UTC) #33
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b349fb9751cd9f6b2667db7819e5f6c8c9254faf
Cr-Commit-Position: refs/heads/master@{#436306}

Powered by Google App Engine
This is Rietveld 408576698