Mojo: Start writing some unit tests for mojo::system::Channel.

Mojo: Start writing some unit tests for mojo::system::Channel.

Also make RawChannels destroyable without DCHECK failures if OnInit()
fails.

R=yzshen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266193

[yzshen1, 2014-04-25 05:14:55]

LGTM

https://codereview.chromium.org/251483007/diff/1/mojo/system/channel_unittest.cc
File mojo/system/channel_unittest.cc (right):

https://codereview.chromium.org/251483007/diff/1/mojo/system/channel_unittest...
mojo/system/channel_unittest.cc:25: Tristate BoolToTristate(bool b) {
optional: It seems more intuitive to use two boolean values |init_called_| and
|init_result_| than defining a new type with conversion function.

[viettrungluu, 2014-04-25 05:23:20]

Thanks.

On 2014/04/25 05:14:55, yzshen1 wrote:
> LGTM
> 
>
https://codereview.chromium.org/251483007/diff/1/mojo/system/channel_unittest.cc
> File mojo/system/channel_unittest.cc (right):
> 
>
https://codereview.chromium.org/251483007/diff/1/mojo/system/channel_unittest...
> mojo/system/channel_unittest.cc:25: Tristate BoolToTristate(bool b) {
> optional: It seems more intuitive to use two boolean values |init_called_| and
> |init_result_| than defining a new type with conversion function.

I did this because I expect more things along the same lines (and keeping two
values for each thing is quite annoying).

[viettrungluu, 2014-04-25 05:34:54]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2014-04-25 08:25:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/251483007/30004

[viettrungluu, 2014-04-25 15:19:56]

Committed patchset #3 manually as r266193 (presubmit successful).