Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 251483002: Keep active directory when same root item on navigation list is activated. (Closed)

Created:
6 years, 8 months ago by fukino
Modified:
6 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Keep active directory when same root item on navigation list is activated. NavigationList's activeModelItem_() is called even when the actual active model is not changed. It occurs when the list items on navigation list are permutated by mounting/unmounting devices. This patch checks if the actual active model is changed. Code for clearing selection on clicking root items is moved to click event handler. BUG=361047 TEST=manually tested ran browser_tests gtest_filter=*FileManager* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266507

Patch Set 1 #

Patch Set 2 : Modify comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/navigation_list.js View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
fukino
yoshiki san, could you take a look? This CL is for the issue discussed today.
6 years, 8 months ago (2014-04-24 11:14:21 UTC) #1
yoshiki
LGTM with nit. Thanks for doing this! nit: Please add "TEST" field in the description. ...
6 years, 8 months ago (2014-04-24 12:02:20 UTC) #2
fukino
On 2014/04/24 12:02:20, yoshiki wrote: > LGTM with nit. Thanks for doing this! > > ...
6 years, 8 months ago (2014-04-25 02:06:49 UTC) #3
yoshiki
On 2014/04/25 02:06:49, fukino wrote: > On 2014/04/24 12:02:20, yoshiki wrote: > > LGTM with ...
6 years, 8 months ago (2014-04-25 02:15:53 UTC) #4
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 7 months ago (2014-04-28 02:34:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/251483002/20001
6 years, 7 months ago (2014-04-28 02:36:01 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 11:52:48 UTC) #7
Message was sent while issue was closed.
Change committed as 266507

Powered by Google App Engine
This is Rietveld 408576698