Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2514783003: Avoid shoing progress bar on "pending" download notifications. They still should remain "ongoing". (Closed)

Created:
4 years, 1 month ago by Dmitry Titov
Modified:
4 years, 1 month ago
Reviewers:
qinmin
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid shoing progress bar on "pending" download notifications. They still should remain "ongoing". BUG=667011 Committed: https://crrev.com/10ed1daf560c4d99c6f5235878680d88d48c1307 Cr-Commit-Position: refs/heads/master@{#433957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Dmitry Titov
4 years, 1 month ago (2016-11-19 02:47:55 UTC) #2
qinmin
lgtm
4 years, 1 month ago (2016-11-21 19:26:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514783003/1
4 years, 1 month ago (2016-11-22 18:44:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/168668)
4 years, 1 month ago (2016-11-22 19:07:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514783003/1
4 years, 1 month ago (2016-11-22 19:35:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 20:13:58 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 20:17:31 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10ed1daf560c4d99c6f5235878680d88d48c1307
Cr-Commit-Position: refs/heads/master@{#433957}

Powered by Google App Engine
This is Rietveld 408576698