Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

Issue 2514783002: [Cronet] Add callback wrapper classes to enforce API version checking. (Closed)
Patch Set: make constructors public, adjust copyright date Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java
diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java
index bbf20ad2214dde42d6706da39ed9e7020e891ca6..824ae87781ad7c22b2a27cddc8b40498a75a5b15 100644
--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java
+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java
@@ -36,7 +36,7 @@ public final class CronetUploadDataStream extends UploadDataSink {
private static final String TAG = "CronetUploadDataStream";
// These are never changed, once a request starts.
private final Executor mExecutor;
- private final UploadDataProvider mDataProvider;
+ private final VersionSafeCallbacks.UploadDataProviderWrapper mDataProvider;
kapishnikov 2016/11/18 16:32:57 Same here. We should keep UploadDataProvider. Appl
pauljensen 2016/11/18 19:18:07 I think that defeats the purpose of this CL. User
kapishnikov 2016/11/18 19:39:15 Acknowledged.
private long mLength;
private long mRemainingLength;
private CronetUrlRequest mRequest;
@@ -98,7 +98,7 @@ public final class CronetUploadDataStream extends UploadDataSink {
*/
public CronetUploadDataStream(UploadDataProvider dataProvider, Executor executor) {
mExecutor = executor;
- mDataProvider = dataProvider;
+ mDataProvider = new VersionSafeCallbacks.UploadDataProviderWrapper(dataProvider);
}
/**

Powered by Google App Engine
This is Rietveld 408576698