Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2514763002: [ios] Adds theme resources for the toolbar buttons. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), oshima+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds theme resources for the toolbar buttons. BUG=666732 Committed: https://crrev.com/9a7f1d89aae6bc4b1886aab02079bd9ef88fb4ea Cr-Commit-Position: refs/heads/master@{#433192}

Patch Set 1 #

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
A ios/chrome/app/theme/default_100_percent/toolbar_dark_back.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_back_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_back_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_background.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_forward.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_forward_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_forward_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_overview.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_overview_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_overview_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_reload.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_reload_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_reload_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_share.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_share_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_share_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_star.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_star_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_stop.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_stop_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_stop_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_tools.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_tools_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_voice.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_dark_voice_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_back.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_back_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_back_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_background.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_callingapp.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_callingapp_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_forward.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_forward_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_forward_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_overview.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_overview_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_overview_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_reload.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_reload_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_reload_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_share.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_share_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_share_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_star.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_star_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_stop.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_stop_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_stop_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_tools.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_tools_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_voice.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_light_voice_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_shadow.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_shadow_full_bleed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_tts.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_100_percent/toolbar_tts_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_back.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_back_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_back_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_background.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_forward.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_forward_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_forward_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_overview.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_overview_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_overview_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_reload.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_reload_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_reload_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_share.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_share_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_share_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_star.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_star_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_stop.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_stop_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_stop_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_tools.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_tools_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_voice.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_dark_voice_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_back.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_back_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_back_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_background.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_callingapp.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_callingapp_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_forward.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_forward_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_forward_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_overview.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_overview_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_overview_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_reload.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_reload_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_reload_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_share.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_share_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_share_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_star.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_star_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_stop.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_stop_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_stop_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_tools.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_tools_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_voice.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_light_voice_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_shadow.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_shadow_full_bleed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_tts.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_200_percent/toolbar_tts_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_back.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_back_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_back_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_background.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_forward.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_forward_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_forward_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_overview.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_overview_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_overview_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_reload.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_reload_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_reload_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_share.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_share_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_share_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_star.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_star_filled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_stop.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_stop_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_stop_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_tools.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_tools_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_voice.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_dark_voice_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_back.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_back_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_back_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_background.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_callingapp.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_callingapp_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_forward.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_forward_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_forward_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_overview.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_overview_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_overview_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_reload.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_reload_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_reload_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_share.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_share_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_share_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_star.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_star_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_stop.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_stop_disabled.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_stop_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_tools.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_tools_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_voice.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_light_voice_pressed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_shadow.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_shadow_full_bleed.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_tts.png View Binary file 0 comments Download
A ios/chrome/app/theme/default_300_percent/toolbar_tts_pressed.png View Binary file 0 comments Download
M ios/chrome/app/theme/ios_theme_resources.grd View 1 2 chunks +65 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
rohitrao (ping after 24h)
4 years, 1 month ago (2016-11-18 14:10:41 UTC) #5
sdefresne
rs lgtm
4 years, 1 month ago (2016-11-18 14:19:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514763002/20001
4 years, 1 month ago (2016-11-18 14:27:45 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 14:35:57 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 14:38:44 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9a7f1d89aae6bc4b1886aab02079bd9ef88fb4ea
Cr-Commit-Position: refs/heads/master@{#433192}

Powered by Google App Engine
This is Rietveld 408576698