Add Mir credit card support to autofill.

Add Mir credit card support to autofill.

BUG=664943
Committed: https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655
Cr-Commit-Position: refs/heads/master@{#435085}

[sense (YandexTeam), 2016-11-18 08:56:58]

Patchset #1 (id:1) has been deleted

[sense (YandexTeam), 2016-11-18 08:59:14]

The CQ bit was checked by sense@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 08:59:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sense (YandexTeam), 2016-11-18 09:56:10]

sense@yandex-team.ru changed reviewers:
+ jochen@chromium.org, rouslan@chromium.org

[please use gerrit instead, 2016-11-18 10:34:21]

Please run your images through tools/resources/optimize-png-files.sh and remove
any changes related to the sync server, which does not yet support MIR cards.

https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_sync_constants.cc (right):

https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_sync_constants.cc:14: const char
kSyncCardTypeMir[] = "MIR";
No need to add here.

https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_sync_constants.h (right):

https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_sync_constants.h:14: extern const char
kSyncCardTypeMir[];
No need to add MIR in autofill_sync_constants.h, because the sync server does
not yet support MIR. This will be done by sync engineers later on.

https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
File
components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
(right):

https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc:46:
return kMirCard;
No need to add here.

https://codereview.chromium.org/2514753002/diff/20001/components/sync/protoco...
File components/sync/protocol/autofill_specifics.proto (right):

https://codereview.chromium.org/2514753002/diff/20001/components/sync/protoco...
components/sync/protocol/autofill_specifics.proto:93: MIR = 9;
No need to modify anything sync server related.

https://codereview.chromium.org/2514753002/diff/20001/components/sync/protoco...
File components/sync/protocol/proto_enum_conversions.cc (right):

https://codereview.chromium.org/2514753002/diff/20001/components/sync/protoco...
components/sync/protocol/proto_enum_conversions.cc:248:
ENUM_CASE(sync_pb::WalletMaskedCreditCard, MIR);
No need to modify anything sync server related.

[commit-bot: I haz the power, 2016-11-18 11:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 11:17:56]

Dry run: This issue passed the CQ dry run.

[sense (YandexTeam), 2016-11-21 08:03:55]

On 2016/11/18 10:34:21, rouslan wrote:
> Please run your images through tools/resources/optimize-png-files.sh and
remove
> any changes related to the sync server, which does not yet support MIR cards.
> 
>
https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
> File components/autofill/core/browser/autofill_sync_constants.cc (right):
> 
>
https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
> components/autofill/core/browser/autofill_sync_constants.cc:14: const char
> kSyncCardTypeMir[] = "MIR";
> No need to add here.
> 
>
https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
> File components/autofill/core/browser/autofill_sync_constants.h (right):
> 
>
https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
> components/autofill/core/browser/autofill_sync_constants.h:14: extern const
char
> kSyncCardTypeMir[];
> No need to add MIR in autofill_sync_constants.h, because the sync server does
> not yet support MIR. This will be done by sync engineers later on.
> 
>
https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
> File
> components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
> (right):
> 
>
https://codereview.chromium.org/2514753002/diff/20001/components/autofill/cor...
>
components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc:46:
> return kMirCard;
> No need to add here.
> 
>
https://codereview.chromium.org/2514753002/diff/20001/components/sync/protoco...
> File components/sync/protocol/autofill_specifics.proto (right):
> 
>
https://codereview.chromium.org/2514753002/diff/20001/components/sync/protoco...
> components/sync/protocol/autofill_specifics.proto:93: MIR = 9;
> No need to modify anything sync server related.
> 
>
https://codereview.chromium.org/2514753002/diff/20001/components/sync/protoco...
> File components/sync/protocol/proto_enum_conversions.cc (right):
> 
>
https://codereview.chromium.org/2514753002/diff/20001/components/sync/protoco...
> components/sync/protocol/proto_enum_conversions.cc:248:
> ENUM_CASE(sync_pb::WalletMaskedCreditCard, MIR);
> No need to modify anything sync server related.

Thank you, that makes sense. I wasn't sure if I should do it or not.  I've
removed all sync-related stuff and optimized PNGs. Please take a look again.

[jochen (gone - plz use gerrit), 2016-11-21 11:08:33]

jochen@chromium.org changed reviewers:
+ brettw@chromium.org

[jochen (gone - plz use gerrit), 2016-11-21 11:08:33]

+brettw who might have an opinion on this

[please use gerrit instead, 2016-11-21 15:16:18]

lgtm

[brettw, 2016-11-21 16:41:45]

lgtm

[sense (YandexTeam), 2016-11-22 03:40:01]

The CQ bit was checked by sense@yandex-team.ru

[commit-bot: I haz the power, 2016-11-22 03:40:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sense (YandexTeam), 2016-11-22 03:47:43]

Description was changed from

==========
Add Mir credit card support to autofill.

BUG=664943
==========

to

==========
Add Mir credit card support to autofill.

BUG=664943
==========

[sense (YandexTeam), 2016-11-22 03:47:43]

sense@yandex-team.ru changed reviewers:
+ dtrainor@chromium.org

[commit-bot: I haz the power, 2016-11-22 03:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 03:48:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sense (YandexTeam), 2016-11-22 03:52:40]

dtrainor@ could you please take a look at png files in android/java/res
directory? I can't commit this without your approve.

[sense (YandexTeam), 2016-11-24 09:26:59]

sense@yandex-team.ru changed reviewers:
+ ianwen@chromium.org
- dtrainor@chromium.org

[sense (YandexTeam), 2016-11-24 09:28:10]

On 2016/11/22 03:52:40, sense (YandexTeam) wrote:
> dtrainor@ could you please take a look at png files in android/java/res
> directory? I can't commit this without your approve.

ianwen@ could you please take a look at png files in android/java/res
directory? I can't commit this CL without approve.

[Ian Wen, 2016-11-28 18:18:06]

Hello!

I have two questions with the PNG files here:

1. Do you happen to have a SVG version of the icons? If so you could use them as
vector drawables, and save Chrome some APK size.
2. If you do not have SVG, have you run png-crush on the PNG files? You can find
the script to do it here:
https://cs.chromium.org/chromium/src/tools/resources/optimize-png-files.sh

[sense (YandexTeam), 2016-11-29 05:46:41]

On 2016/11/28 18:18:06, Ian Wen wrote:
> Hello!
> 
> I have two questions with the PNG files here:
> 
> 1. Do you happen to have a SVG version of the icons? If so you could use them
as
> vector drawables, and save Chrome some APK size.
> 2. If you do not have SVG, have you run png-crush on the PNG files? You can
find
> the script to do it here:
> https://cs.chromium.org/chromium/src/tools/resources/optimize-png-files.sh

Hello Ian,
No, I don't have an SVG version of the icons, but I used png-crush on the PNG
files as rouslan@ suggested.

[Ian Wen, 2016-11-29 19:53:15]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-11-29 19:53:16]

lgtm

Great.

[commit-bot: I haz the power, 2016-11-29 19:53:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 21:59:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480449195717970,
"parent_rev": "edb1f289a32295117c6217cd3c27f261078491b2", "commit_rev":
"92234d2b3727b7a2bb63ec28cf8fff707f97cf95"}

[commit-bot: I haz the power, 2016-11-29 22:00:22]

Description was changed from

==========
Add Mir credit card support to autofill.

BUG=664943
==========

to

==========
Add Mir credit card support to autofill.

BUG=664943
==========

[commit-bot: I haz the power, 2016-11-29 22:00:23]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-29 22:03:17]

Description was changed from

==========
Add Mir credit card support to autofill.

BUG=664943
==========

to

==========
Add Mir credit card support to autofill.

BUG=664943

Committed: https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655
Cr-Commit-Position: refs/heads/master@{#435085}
==========

[commit-bot: I haz the power, 2016-11-29 22:03:19]

Patchset 2 (id:??) landed as
https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655
Cr-Commit-Position: refs/heads/master@{#435085}