Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2514743002: Use static profile in SelectorQueryTest (Closed)

Created:
4 years, 1 month ago by kochi
Modified:
4 years, 1 month ago
Reviewers:
rune
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use static profile in SelectorQueryTest This change should have been included in https://codereview.chromium.org/2493003003/ Only one instance of CSSParserContext constructor was rewritten to use static profile, and the rest was unchanged. BUG=633007 Committed: https://crrev.com/fb35cc5796f051b0f83867417686746649eea618 Cr-Commit-Position: refs/heads/master@{#433156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kochi
PTAL
4 years, 1 month ago (2016-11-18 07:23:09 UTC) #3
rune
lgtm
4 years, 1 month ago (2016-11-18 08:56:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514743002/1
4 years, 1 month ago (2016-11-18 09:03:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 09:07:11 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 09:09:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb35cc5796f051b0f83867417686746649eea618
Cr-Commit-Position: refs/heads/master@{#433156}

Powered by Google App Engine
This is Rietveld 408576698