Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2514733005: Only apply accessibility font scale factor when autosizing inflates (Closed)

Created:
4 years, 1 month ago by pdr.
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only apply accessibility font scale factor when autosizing inflates The accessibility font scale factor is currently applied to all text that the text autosizer would inflate (this is changing in crbug.com/645717). crrev.com/1229b1414d64c314666d2fb3bf47706f2b5e947b introduced a bug where text that would not be inflated would become inflated if text-size-adjust: none was applied. This patch only applies the accessibility font scale factor if the text autosizer would have inflated the text already. A new test, AccessibilityFontScaleFactorWithTextSizeAdjustNone, has been added. Other tests in TestAutosizerTest.cpp have been reformatted to 80cols. BUG=666378 Committed: https://crrev.com/394de7b0baa6b0136b6acfd15486de6a98e19152 Cr-Commit-Position: refs/heads/master@{#433757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -211 lines) Patch
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp View 13 chunks +187 lines, -208 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
pdr.
4 years, 1 month ago (2016-11-19 04:43:52 UTC) #2
skobes
lgtm
4 years, 1 month ago (2016-11-22 00:04:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514733005/1
4 years, 1 month ago (2016-11-22 00:30:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/302395)
4 years, 1 month ago (2016-11-22 01:08:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514733005/1
4 years, 1 month ago (2016-11-22 01:18:38 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 02:55:27 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 02:59:19 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/394de7b0baa6b0136b6acfd15486de6a98e19152
Cr-Commit-Position: refs/heads/master@{#433757}

Powered by Google App Engine
This is Rietveld 408576698