Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 2514693003: Revert "Enable syntax-only support for generic functions by default." (Closed)

Created:
4 years, 1 month ago by eernst
Modified:
4 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Enable syntax-only support for generic functions by default." This reverts commit 70fa0defe9b416669b6e01acf9f31d49aac3426f. (There were too many tests previously failing and now passing on browsers to fix it right now, will sort it out on Monday.) Committed: https://github.com/dart-lang/sdk/commit/cf4cff38128ada81438a47c847d56f8b81be721e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M pkg/compiler/lib/src/commandline_options.dart View 2 chunks +5 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/generic_functions_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_local_functions_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_methods_function_type_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_methods_generic_function_parameter_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_methods_new_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_methods_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_methods_type_expression_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_sends_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
Committed patchset #1 (id:1) manually as cf4cff38128ada81438a47c847d56f8b81be721e (presubmit successful).
4 years, 1 month ago (2016-11-18 14:54:40 UTC) #2
eernst
TBR. Too many status changes on various browsers to fix right now, hence reverting.
4 years, 1 month ago (2016-11-18 14:57:14 UTC) #4
Johnni Winther
4 years, 1 month ago (2016-11-21 08:19:13 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698