Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Issue 2514693002: [Payments] Display payment method and contact summary in a single line in bottom sheet (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
index cb4aa4ed2f39ae8173d8993008c79d91a361ec72..f7419b78989724b690d1fa5667911b63e8d0bf22 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
@@ -454,7 +454,9 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
// Let the summary display a SELECT/ADD button for the first subsection
// that needs it.
mShippingSummarySection.setSummaryText(null, null);
- mShippingSummarySection.setSummaryProperties(null, false, null, false);
+ mShippingSummarySection.setSummaryProperties(null /* leftTruncate */,
+ false /* leftIsSingleLine */, null /* rightTruncate */,
+ false /* rightIsSingleLine */);
PaymentRequestSection section =
mShippingAddressSection.getEditButtonState() == EDIT_BUTTON_GONE
@@ -463,8 +465,9 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
} else {
// Show the shipping name in the summary section.
mShippingSummarySection.setSummaryText(selectedShippingName, null);
- mShippingSummarySection.setSummaryProperties(
- TruncateAt.END, true, null, false);
+ mShippingSummarySection.setSummaryProperties(TruncateAt.END,
+ true /* leftIsSingleLine */, null /* rightTruncate */,
+ false /* rightIsSingleLine */);
// Show the shipping address, phone and option below the summary.
mShippingSummarySection.setExtraTexts(new String[] {selectedShippingAddress,
@@ -477,9 +480,17 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
}
if (mRequestContactDetails) {
+ // Sets the summary of the contact displays in a single line.
+ mContactDetailsSection.setSummaryProperties(TruncateAt.END,
+ true /* leftIsSingleLine */, null /* rightTruncate */,
+ false /* rightIsSingleLine */);
updateSection(TYPE_CONTACT_DETAILS, result.getContactDetails());
}
+ // Sets the summary of the payment method displays in a single line.
+ mPaymentMethodSection.setSummaryProperties(TruncateAt.END,
+ true /* leftIsSingleLine */, null /* rightTruncate */,
+ false /* rightIsSingleLine */);
updateSection(TYPE_PAYMENT_METHODS, result.getPaymentMethods());
updatePayButtonEnabled();
@@ -974,6 +985,14 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
// Disable all but the first button.
updateSectionButtons();
+ // Sets the summary of the payment method and contact displays in multiple lines.
+ mContactDetailsSection.setSummaryProperties(null /* leftTruncate */,
+ false /* leftIsSingleLine */, null /* rightTruncate */,
+ false /* rightIsSingleLine */);
+ mPaymentMethodSection.setSummaryProperties(null /* leftTruncate */,
+ false /* leftIsSingleLine */, null /* rightTruncate */,
+ false /* rightIsSingleLine */);
+
mIsShowingEditDialog = true;
}

Powered by Google App Engine
This is Rietveld 408576698