Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: src/compiler/wasm-compiler.cc

Issue 2514663002: [simd] Disable Simd Scalar lowering for x64, enable tests for all other architectures. (Closed)
Patch Set: Bill's review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index eaa5b6fec6e2202b476c299589bb5a6863e24c94..cbe6acfa534a525ead39d2c3c6fa3106c8a1381d 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -3080,10 +3080,12 @@ void WasmGraphBuilder::Int64LoweringForTesting() {
}
void WasmGraphBuilder::SimdScalarLoweringForTesting() {
- SimdScalarLowering(jsgraph()->graph(), jsgraph()->machine(),
- jsgraph()->common(), jsgraph()->zone(),
- function_signature_)
- .LowerGraph();
+ if (!CpuFeatures::SupportsSimd128()) {
bbudge 2016/11/21 19:48:09 Can you move the test up into TestGraphBuilder? h
gdeepti 2016/11/21 20:56:39 Done.
+ SimdScalarLowering(jsgraph()->graph(), jsgraph()->machine(),
+ jsgraph()->common(), jsgraph()->zone(),
+ function_signature_)
+ .LowerGraph();
+ }
}
void WasmGraphBuilder::SetSourcePosition(Node* node,
@@ -3348,8 +3350,10 @@ SourcePositionTable* WasmCompilationUnit::BuildGraphForWasmFunction(
r.LowerGraph();
}
- SimdScalarLowering(graph, machine, common, jsgraph_->zone(), function_->sig)
- .LowerGraph();
+ if (!CpuFeatures::SupportsSimd128()) {
+ SimdScalarLowering(graph, machine, common, jsgraph_->zone(), function_->sig)
+ .LowerGraph();
+ }
int index = static_cast<int>(function_->func_index);
« no previous file with comments | « no previous file | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698