Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2514653004: [Cronet] Add Cronet trybot to list of CQ bots for Cronet CLs. (Closed)

Created:
4 years, 1 month ago by pauljensen
Modified:
4 years, 1 month ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Add Cronet trybot to list of CQ bots for Cronet CLs. When a CL is uploaded that modifies components/cronet/, include the android_cronet_tester trybot to the CQ run for that CL. This ensures Cronet tests aren't broken directly by changes to Cronet. R=mef CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Committed: https://crrev.com/6c178bead5fa3066a57814b3bc6a69522c79f352 Cr-Commit-Position: refs/heads/master@{#433324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M components/cronet/PRESUBMIT.py View 4 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pauljensen
Misha, PTAL, thank you!
4 years, 1 month ago (2016-11-18 18:28:25 UTC) #2
mef
lgtm, thanks for doing this!
4 years, 1 month ago (2016-11-18 18:31:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514653004/1
4 years, 1 month ago (2016-11-18 18:34:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet_tester/builds/677)
4 years, 1 month ago (2016-11-18 19:51:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514653004/1
4 years, 1 month ago (2016-11-18 21:03:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 23:07:40 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 23:09:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c178bead5fa3066a57814b3bc6a69522c79f352
Cr-Commit-Position: refs/heads/master@{#433324}

Powered by Google App Engine
This is Rietveld 408576698