Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2514653003: Increase test coverage for Content:// urls (Closed)

Created:
4 years, 1 month ago by sgurun-gerrit only
Modified:
4 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase test coverage for Content:// urls This CL has further fixes to https://codereview.chromium.org/2476823002/ which was reverted as it broke android tests debug bot. Add test for verifying that iframe contents that are served from content urls cannot be accessed by parent page. BUG=659492 Committed: https://crrev.com/cd61283b427438e7c42eac68e24331ea4abf31ee Cr-Commit-Position: refs/heads/master@{#433266}

Patch Set 1 : Initial CL (same as reverted CL) #

Patch Set 2 : fixed the tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -80 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/UrlSchemeTest.java View 1 7 chunks +110 lines, -20 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/TestContentProvider.java View 1 3 chunks +73 lines, -60 lines 0 comments Download
A chrome/test/data/android/page_with_iframe_as_content_url.html View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/android/simple_iframe.html View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sgurun-gerrit only
On 2016/11/18 05:48:48, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:tedchoc@chromium.org Ted, PTAL. This ...
4 years, 1 month ago (2016-11-18 05:50:34 UTC) #3
Ted C
lgtm
4 years, 1 month ago (2016-11-18 17:21:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514653003/20001
4 years, 1 month ago (2016-11-18 18:06:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 19:36:33 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 19:40:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd61283b427438e7c42eac68e24331ea4abf31ee
Cr-Commit-Position: refs/heads/master@{#433266}

Powered by Google App Engine
This is Rietveld 408576698