third_party/WebKit/Source/core/frame/DOMTimer.cpp - Issue 2514643002: DevTools: support all handlers that end up with function call in perfmonitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMTimer.cpp

Issue 2514643002: DevTools: support all handlers that end up with function call in perfmonitor. (Closed)

Patch Set: review comments addressed. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMTimer.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMTimer.cpp b/third_party/WebKit/Source/core/frame/DOMTimer.cpp

index 30fe1c046957604f6eb63a6c780979c91333e446..f3cd7206b7826207d9a7198b07e43f128a53a349 100644

--- a/third_party/WebKit/Source/core/frame/DOMTimer.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMTimer.cpp

@@ -134,7 +134,8 @@ void DOMTimer::fired() {

TRACE_EVENT1("devtools.timeline", "TimerFire", "data",

InspectorTimerFireEvent::data(context, m_timeoutID));

- PerformanceMonitor::HandlerCall handlerCall(context, m_action);

+ PerformanceMonitor::HandlerCall handlerCall(

+ context, repeatInterval() ? "setInterval" : "setTimeout", true);

InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(

context, "timerFired", false);

InspectorInstrumentation::AsyncTask asyncTask(context, this);