Source/core/animation/Keyframe.h - Issue 251463003: Web Animations API: Sort keyframes by offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/Keyframe.h

Issue 251463003: Web Animations API: Sort keyframes by offset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Detect null offset Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/Keyframe.h

diff --git a/Source/core/animation/Keyframe.h b/Source/core/animation/Keyframe.h

index c9fab1de8453bc683f8acd9fdf7d268c4cb3400e..2e0f9333da87fb3b794f3b44875bba7e3e5554c1 100644

--- a/Source/core/animation/Keyframe.h

+++ b/Source/core/animation/Keyframe.h

@@ -30,7 +30,11 @@ public:

void setEasing(PassRefPtr<TimingFunction> easing) { m_easing = easing; }

TimingFunction* easing() const { return m_easing.get(); }

- static bool compareOffsets(const RefPtrWillBeMember<Keyframe>&, const RefPtrWillBeMember<Keyframe>&);

+ static bool compareOffsets(const RefPtrWillBeMember<Keyframe>& a, const RefPtrWillBeMember<Keyframe>& b)

+ {

+ return a->offset() < b->offset();

+ }

virtual PropertySet properties() const = 0;

virtual PassRefPtrWillBeRawPtr<Keyframe> clone() const = 0;