Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 25146008: Disable externalization of sliced/cons strings in old pointer space. (Closed)

Created:
7 years, 2 months ago by Jakob Kummerow
Modified:
7 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Disable externalization of sliced/cons strings in old pointer space. This is a temporary workaround for the fact that a good deal of the code that triggers access checks, which in turn externalize strings, is not yet handlified and therefore not GC safe. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
As discussed.
7 years, 2 months ago (2013-09-30 16:36:34 UTC) #1
Yang
On 2013/09/30 16:36:34, Jakob wrote: > As discussed. lgtm.
7 years, 2 months ago (2013-09-30 16:37:29 UTC) #2
Jakob Kummerow
7 years, 2 months ago (2013-09-30 16:42:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17023 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698