Don't create mementos for shallow SMI array literals in crankshaft

In crankshafted code, we were creating allocation mementos for shallow
SMI array literals when we shouldn't. The idea is that we should have learned
by this point what type of array we'll end up with.

R=hpayer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17028

[mvstanton, 2013-09-30 14:37:39]

Hi Hannes, PTAL, thx!
--Michael

[Hannes Payer (out of office), 2013-09-30 19:12:52]

LGTM, minior nits.

https://codereview.chromium.org/25146007/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/25146007/diff/1/src/hydrogen.cc#newcode8368
src/hydrogen.cc:8368: Handle<FixedArrayBase>
elements(boilerplate_object->elements());
Since you are already here, could you move elements down to int elements_size
where it is used?

https://codereview.chromium.org/25146007/diff/1/src/hydrogen.cc#newcode8369
src/hydrogen.cc:8369: int object_size =
boilerplate_object->map()->instance_size();
You could delete object_size...

https://codereview.chromium.org/25146007/diff/1/src/hydrogen.cc#newcode8375
src/hydrogen.cc:8375: HValue* object_size_constant =
Add<HConstant>(object_size);
and change that line to:
HValue* object_size =
    Add<HConstant>(boilerplate_object->map()->instance_size());

[mvstanton, 2013-09-30 20:50:33]

right on, thanks much!
--Michael

https://codereview.chromium.org/25146007/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/25146007/diff/1/src/hydrogen.cc#newcode8368
src/hydrogen.cc:8368: Handle<FixedArrayBase>
elements(boilerplate_object->elements());
On 2013/09/30 19:12:52, Hannes Payer wrote:
> Since you are already here, could you move elements down to int elements_size
> where it is used?

Done.

https://codereview.chromium.org/25146007/diff/1/src/hydrogen.cc#newcode8369
src/hydrogen.cc:8369: int object_size =
boilerplate_object->map()->instance_size();
On 2013/09/30 19:12:52, Hannes Payer wrote:
> You could delete object_size...

Done.

https://codereview.chromium.org/25146007/diff/1/src/hydrogen.cc#newcode8375
src/hydrogen.cc:8375: HValue* object_size_constant =
Add<HConstant>(object_size);
On 2013/09/30 19:12:52, Hannes Payer wrote:
> and change that line to:
> HValue* object_size =
>     Add<HConstant>(boilerplate_object->map()->instance_size());

Done.

[mvstanton, 2013-10-01 08:22:09]

Committed patchset #2 manually as r17028 (presubmit successful).