Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/common/variations/child_process_field_trial_syncer_unittest.cc

Issue 2514593002: Field trial synchronization to PPAPI process. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/variations/child_process_field_trial_syncer.h"
6
7 #include <string>
8 #include <utility>
9 #include <vector>
10
11 #include "base/base_switches.h"
12 #include "base/command_line.h"
13 #include "base/message_loop/message_loop.h"
14 #include "base/metrics/field_trial.h"
15 #include "base/run_loop.h"
16 #include "testing/gtest/include/gtest/gtest.h"
17
18 namespace chrome_variations {
19
20 namespace {
21
22 // TestFieldTrialObserver to listen to be notified by the child process syncer.
23 class TestFieldTrialObserver : public base::FieldTrialList::Observer {
24 public:
25 TestFieldTrialObserver() {}
26 ~TestFieldTrialObserver() override {}
27
28 // base::FieldTrial::Observer:
29 void OnFieldTrialGroupFinalized(const std::string& trial_name,
30 const std::string& group_name) override {
31 observed_entries_.push_back(std::make_pair(trial_name, group_name));
32 }
33
34 size_t observed_entries_count() const { return observed_entries_.size(); }
35
36 std::pair<std::string, std::string> get_observed_entry(int i) const {
37 return observed_entries_[i];
38 }
39
40 private:
41 std::vector<std::pair<std::string, std::string>> observed_entries_;
42
43 DISALLOW_COPY_AND_ASSIGN(TestFieldTrialObserver);
44 };
45
46 // Needed because make_pair("a", "b") doesn't convert to std::string pair.
47 std::pair<std::string, std::string> MakeStringPair(const std::string& a,
48 const std::string& b) {
49 return std::make_pair(a, b);
50 }
51
52 } // namespace
53
54 TEST(ChildProcessFieldTrialSyncerTest, FieldTrialState) {
55 base::MessageLoop message_loop;
56 base::FieldTrialList field_trial_list(nullptr);
57
58 base::FieldTrial* trial1 = base::FieldTrialList::CreateFieldTrial("A", "G1");
59 base::FieldTrial* trial2 = base::FieldTrialList::CreateFieldTrial("B", "G2");
60 base::FieldTrial* trial3 = base::FieldTrialList::CreateFieldTrial("C", "G3");
61 // Activate trial3 before command line is produced.
62 trial1->group();
63
64 std::string states_string;
65 base::FieldTrialList::AllStatesToString(&states_string);
66
67 base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
68 switches::kForceFieldTrials, states_string);
69 EXPECT_EQ("*A/G1/B/G2/C/G3/", states_string);
70
71 // Active trial 2 before creating the syncer.
72 trial2->group();
73
74 TestFieldTrialObserver observer;
75 ChildProcessFieldTrialSyncer syncer(&observer);
76 syncer.InitFieldTrialObserving(*base::CommandLine::ForCurrentProcess());
77
78 // The observer should be notified of activated entries that were not activate
79 // on the command line. In this case, trial 2. (Trial 1 was already active via
80 // command line and so its state shouldn't be notified.)
81 ASSERT_EQ(1U, observer.observed_entries_count());
82 EXPECT_EQ(MakeStringPair("B", "G2"), observer.get_observed_entry(0));
83
84 // Now, activate trial 3, which should also get reflected.
85 trial3->group();
86 // Notifications from field trial activation actually happen via posted tasks,
87 // so invoke the run loop.
88 base::RunLoop().RunUntilIdle();
89
90 ASSERT_EQ(2U, observer.observed_entries_count());
91 EXPECT_EQ(MakeStringPair("C", "G3"), observer.get_observed_entry(1));
92 }
93
94 } // namespace chrome_variations
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698