Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp

Issue 2514573003: Update documentation and cleanup impls for localToSVGParentTransform() (Closed)
Patch Set: Update again Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
index a1b5d8d38b837ef41695618d074a7a604b1c9361..39308cdea900542bc53cf37959e7bb44ba4485f6 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
@@ -72,12 +72,9 @@ FloatRect LayoutSVGResourceMarker::markerBoundaries(
return markerTransformation.mapRect(coordinates);
}
-const AffineTransform& LayoutSVGResourceMarker::localToSVGParentTransform()
- const {
- m_localToParentTransform =
- AffineTransform::translation(m_viewport.x(), m_viewport.y()) *
- viewportTransform();
- return m_localToParentTransform;
+AffineTransform LayoutSVGResourceMarker::localToSVGParentTransform() const {
+ return AffineTransform::translation(m_viewport.x(), m_viewport.y()) *
+ viewportTransform();
// If this class were ever given a localTransform(), then the above would
pdr. 2016/11/18 20:35:10 Can you remove this comment?
Xianzhu 2016/11/18 22:19:12 Done.
// read:
// return viewportTranslation * localTransform() * viewportTransform();

Powered by Google App Engine
This is Rietveld 408576698