third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h - Issue 2514573003: Update documentation and cleanup impls for localToSVGParentTransform()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h

Issue 2514573003: Update documentation and cleanup impls for localToSVGParentTransform() (Closed)

Patch Set: - Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h

index eb76699ca599aff82444d0847f90fd62b2eb1287..37e2d380d0d2dffd54acefa1ca273a4049a81b18 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h

@@ -121,7 +121,7 @@ class CORE_EXPORT LayoutSVGRoot final : public LayoutReplaced {

void insertedIntoTree() override;

void willBeRemovedFromTree() override;

- const AffineTransform& localToSVGParentTransform() const override;

+ AffineTransform localToSVGParentTransform() const override;

FloatRect objectBoundingBox() const override { return m_objectBoundingBox; }

FloatRect strokeBoundingBox() const override { return m_strokeBoundingBox; }

@@ -165,7 +165,6 @@ class CORE_EXPORT LayoutSVGRoot final : public LayoutReplaced {

bool m_objectBoundingBoxValid;

FloatRect m_strokeBoundingBox;

FloatRect m_visualRectInLocalSVGCoordinates;

- mutable AffineTransform m_localToParentTransform;

AffineTransform m_localToBorderBoxTransform;

bool m_isLayoutSizeChanged : 1;

bool m_didScreenScaleFactorChange : 1;