Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2514573002: isPageLogicalHeightKnown() doesn't need a parameter. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

isPageLogicalHeightKnown() doesn't need a parameter. If page logical height is (un)known, it's (un)known throughout the entire fragmentation context, so location doesn't matter. Committed: https://crrev.com/bd0d9c52947c4db46e946743783660bd06354359 Cr-Commit-Position: refs/heads/master@{#433145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
This is actually a prerequisite for the pagination code cleanup than needs to precede the ...
4 years, 1 month ago (2016-11-17 21:49:52 UTC) #4
szager1
lgtm
4 years, 1 month ago (2016-11-17 22:08:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514573002/1
4 years, 1 month ago (2016-11-18 06:28:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 08:03:44 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 08:06:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd0d9c52947c4db46e946743783660bd06354359
Cr-Commit-Position: refs/heads/master@{#433145}

Powered by Google App Engine
This is Rietveld 408576698